Downgrade pcre2 to 10.44 #20380
Merged
Downgrade pcre2 to 10.44 #20380
+10,771
−19,759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Nov 3, 2025
| caches across differing environments). (ilutov) | ||
|
|
||
| - PCRE: | ||
| . Downgrade back to PCRE2 10.44, see GH-20341. (nielsdos) |
Contributor
There was a problem hiding this comment.
It would be good to have a test for the issue so any future upgrade does not break it again.
Also, did you considered backporting PCRE2Project/pcre2#841 a few lines fix?
Member
Author
There was a problem hiding this comment.
It depends on the RM opinion whether we'll backport or go with this (once that PR is accepted).
In #20341 @DanielEScherzer suggested downgrading.
Member
There was a problem hiding this comment.
We shouldn't backport the upstream patch until it is merged upstream.
Given that RC4 is being tagged tomorrow, we should have 8.5 with a version of PCRE2 that isn't broken
DanielEScherzer
approved these changes
Nov 3, 2025
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
RM approval, technical review not performed
edorian
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.