Skip to content

Throw exception when opening menu with no items #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2018
Merged

Throw exception when opening menu with no items #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/CliMenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,10 @@ public function open() : void
if ($this->isOpen()) {
return;
}

if (count($this->items) === 0) {
throw new \RuntimeException('Menu must have at least 1 item before it can be opened');
}

$this->configureTerminal();
$this->open = true;
Expand Down
10 changes: 9 additions & 1 deletion test/CliMenuTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,11 +359,19 @@ public function testThrowsExceptionIfTerminalIsNotValidTTY() : void
->method('isInteractive')
->willReturn(false);

$menu = new CliMenu('PHP School FTW', [], $terminal);
$menu = new CliMenu('PHP School FTW', [new StaticItem('One')], $terminal);

$menu->open();
}

public function testOpenThrowsExceptionIfNoItemsInMenu() : void
{
$this->expectException(\RuntimeException::class);
$this->expectExceptionMessage('Menu must have at least 1 item before it can be opened');

(new CliMenu('PHP School FTW', [], $this->terminal))->open();
}

public function testGetTerminal() : void
{
$menu = new CliMenu('PHP School FTW', []);
Expand Down