This repository was archived by the owner on Jul 16, 2025. It is now read-only.
feat: add option to keep tool messages #323
Merged
+89
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipheimboeck
force-pushed
the
philip/feat-keep-tool-messages
branch
from
bbd5a85 to
41a01a3
Compare
chr-hertel
reviewed
May 24, 2025
chr-hertel
reviewed
May 24, 2025
chr-hertel
suggested changes
May 24, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
implementation looks good - only smaller things on docs & tests
philipheimboeck
force-pushed
the
philip/feat-keep-tool-messages
branch
from
41a01a3 to
f1060b7
Compare
Contributor
Author
|
I rebased the whole thing as meanwhile the namespaces changed and applied your suggestions. |
chr-hertel
approved these changes
Jun 6, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Thanks @philipheimboeck! Great first contribution!
Member
|
I'll take care of the PHPUnit issue after merging, it's a PHPUnit bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the Toolbox/ChainProcessor to keep tool messages by avoiding to clone the original messageBag
Fixes #321