Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Conversation

@OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Jan 6, 2025

Otherwise I experienced, if it has no info, it starts to imagine a value, just to fulfill the schema

@OskarStark OskarStark self-assigned this Jan 6, 2025
@OskarStark OskarStark changed the title feature/allow null Allow null as type in schema Jan 6, 2025
@OskarStark OskarStark added the enhancement New feature or request label Jan 6, 2025
@OskarStark OskarStark requested a review from chr-hertel January 6, 2025 17:51
@OskarStark OskarStark changed the title Allow null as type in schema Allow null as type in schema Jan 6, 2025
@chr-hertel
Copy link
Member

Arrays could be nullable as well and I wonder if that maybe better to have it in SchemaFactory::buildSchema:61 - to have that logic once instead of having the if for every type again

@OskarStark
Copy link
Contributor Author

Will check later and yes I forgot about arrays

@OskarStark
Copy link
Contributor Author

PR updated, like it!

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci 🙏

@chr-hertel chr-hertel merged commit 9b530fc into main Jan 22, 2025
7 checks passed
@chr-hertel chr-hertel deleted the feature/allow-null branch January 22, 2025 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants