-
Notifications
You must be signed in to change notification settings - Fork 23
Register tools without #[AsTool] attribute
#160
Register tools without #[AsTool] attribute
#160
Conversation
4abb4ee to
911dcb0
Compare
1d88087 to
12816f9
Compare
|
|
||
| use Symfony\Component\Clock\ClockInterface; | ||
|
|
||
| final readonly class ClockWithoutAttribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a tool should be added to the tests/ folder, as we don't need to ship two clock tools, doing the exact same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this added example . I already added a fixture test without the attribute .
The idea was to provide an example of tool without "AsTool" .
I deleted this attribute from clock tool to show that case .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need an example for this, but rather a test, so please keep the clock with the attribute and the example and extend ToolboxTestCase with a fixture file, shown, that this tool will be registered. thanks
#[AsTool] attribute
|
Thank you @Iyadhfaleh for your idea to solve this - i'm currently not fully convinced since this is really limited - no description and only |
The idea is to add tools that haven't
#[AsTool]attribute like this :Tools MUST implement
__invokemethod.