added initial wasm gamepad support for ds4 #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds gamepad support for the WASM build using the JS gamepad api, per issue #39.
Initial support is for the DualShock 4, but other gamepads should be addable as well.
On firefox for android (and perhaps others) the gamepad.id is just set to "android", making gamepad fingerprinting kind of impossible, so for now any gamepad with id:"android" is just assumed to be a DualShock 4.
This patch was tested and working on the following browsers:
ubuntu 20.04: firefox 130.0, chromium 128.0.6613.84
android 14: firefox 130.0, vanadium 128.0.6613.99