Fix missing head string in fingerprint of an unexpected CALL statement #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a fingerprint for an CALL statement with some extra string in the head, it will return a fingerprint of a normal CALL statement, for example,
EXPLAIN call test.testCall('test')=>call test.testCall, the extra string in the head is missing.I understand EXPLAIN doesn't support CALL statement, if it only intends to generate fingerprint for vaild SQL, then it should return something else instead of a normal CALL fingerprint. If it intends to generate fingerprint for any SQL that could be logged in slow query log, then I think the patch in this pull request should be merged (or maybe someone has a better idea).
PS: It seems that PMM-2.0 has the same problem
cc @gordan-bobic