bluetooth-fw/nimble_store: pretend to persist CCCDs #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS, on the *second* connection attempt to a cc256x device from the legacy app, the PPoG session will never wake up; we'll see an attempted write to the GATT Service Changed CCCD, but we'll respond with an "Insufficient Authorization (0x08)". What on earth? Nobody even references BLE_ATT_ERR_INSUFFICIENT_AUTHOR! But, it turns out, 0x08 is shared with BLE_HS_ENOTSUP, and we *can* end up returning that from the nimble_store code by way of `ble_gatts_clt_cfg_access` -- and this only happens on the *second* time, because, according to `ble_gatts_clt_cfg_access_locked`, "Successful writes get persisted for bonded connections.". When this happens, unrelated things go wrong later (like PPoG, for some reason). Well, we cheat: we don't actually persist it, since our store is not complex enough to persist it to. But nobody cares, so it's OK. Fixes pebble-dev#260. Signed-off-by: Joshua Wise <[email protected]>
|
Interesting finding, that may explain some other issues we observe actually. Let me check if we need to store something (even if in RAM) that may be needed on some scenarios. |
Hexxeh
approved these changes
Aug 4, 2025
|
Maybe create a ticket to also track this? |
|
I have implemented support for CCCD persistence here coredevices/PebbleOS#149, i a way that should not break the existing db (except you have >= 128 bondings, which seems unrealistic) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, on the second connection attempt to a cc256x device from the legacy app, the PPoG session will never wake up; we'll see an attempted write to the GATT Service Changed CCCD, but we'll respond with an "Insufficient Authorization (0x08)". What on earth? Nobody even references BLE_ATT_ERR_INSUFFICIENT_AUTHOR! But, it turns out, 0x08 is shared with BLE_HS_ENOTSUP, and we can end up returning that from the nimble_store code by way of
ble_gatts_clt_cfg_access-- and this only happens on the second time, because, according toble_gatts_clt_cfg_access_locked, "Successful writes get persisted for bonded connections.". When this happens, unrelated things go wrong later (like PPoG, for some reason).Well, we cheat: we don't actually persist it, since our store is not complex enough to persist it to. But nobody cares, so it's OK.
Fixes #260.