Skip to content

Update contributing guidelines #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

Update contributing guidelines #3341

merged 1 commit into from
Dec 17, 2021

Conversation

@richardtorres314
Copy link
Contributor

@richardtorres314 richardtorres314 commented Dec 16, 2021

This PR is a simple update to the contributing guidelines as per the conversation in the PR #3324.

Also, should we put a note in the CONTRIBUTING.md file about making sure to update types if there are changes?

Definitively a good idea!

HackbrettXXX
HackbrettXXX approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@HackbrettXXX HackbrettXXX merged commit bcd9900 into parallax:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@richardtorres314 @HackbrettXXX