Skip to content

feat(reth-optimism-node): Add OP E2E mineblock test with isthmus activated at genesis #19305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(reth-optimism-node): Add OP E2E mineblock test with isthmus activated at genesis #19305

wants to merge 2 commits into from
+98 −18

Conversation

@mablr
Copy link
Contributor

@mablr mablr commented Oct 26, 2025 •
edited
Loading

Closes #15447

  • duplicated test_testsuite_op_assert_mine_block but with isthmus activated at genesis
  • workaround to handle both v2/v3 payloads (tell me if you'd like another design/approach)

@mablr
feat(tests): add e2e test for block mining with Isthmus activated at …
4cf82ee 
…genesis

- duplicated `test_testsuite_op_assert_mine_block` but with isthmus at genesis
- improved fork choice handling
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 26, 2025
@mablr mablr changed the title feat(reth): Add OP E2E mineblock test with isthmus activated at genesis feat(reth-optimism-node): Add OP E2E mineblock test with isthmus activated at genesis Oct 26, 2025
@mablr mablr marked this pull request as ready for review October 26, 2025 21:19
emhane
emhane requested changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! smol comment on log format

crates/e2e-test-utils/src/testsuite/actions/produce_blocks.rs Outdated
.await
{
Ok(fcu_result) => {
debug!("FCU v2 result: {:?}", fcu_result);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
debug!("FCU v2 result: {:?}", fcu_result);
debug!(
?fcu_result,
"FCU v2 result"
);

we use this kv-pair format for logs. see the tracing docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I made the same mistake as last time. I swear I'll keep it in mind this time.😅

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 27, 2025
emhane
emhane approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. pending @mattsse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add OP E2E mineblock test with isthmus activated at genesis

2 participants

@mablr @emhane