Skip to content

Conversation

@theochap
Copy link
Contributor

Description

In Jovian, the blob_gas_used field has been repurposed to hold the DA footprint block limit value computed during block execution. We should change consensus rules to diverge from the L1 behavior from Jovian onwards.

Added tests to increment coverage on this behavior.

@theochap theochap requested a review from fgimenez as a code owner October 26, 2025 17:28
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 26, 2025
@theochap theochap force-pushed the theo/fix-block-validation-jovian branch 2 times, most recently from 24faf2b to 783cf80 Compare October 26, 2025 17:39
@theochap theochap force-pushed the theo/fix-block-validation-jovian branch from 783cf80 to a6f5f25 Compare October 26, 2025 17:46
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me

pending @klkvr @emhane

Comment on lines +120 to 122
} else if self.chain_spec.is_ecotone_active_at_timestamp(block.timestamp()) {
validate_cancun_gas(block)?;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this else if looks correct to me

because this does

pub fn validate_cancun_gas<B: Block>(block: &SealedBlock<B>) -> Result<(), ConsensusError> {
// Check that the blob gas used in the header matches the sum of the blob gas used by each
// blob tx
let header_blob_gas_used = block.blob_gas_used().ok_or(ConsensusError::BlobGasUsedMissing)?;
let total_blob_gas = block.body().blob_gas_used();
if total_blob_gas != header_blob_gas_used {
return Err(ConsensusError::BlobGasUsedDiff(GotExpected {
got: header_blob_gas_used,
expected: total_blob_gas,
}));
}
Ok(())
}

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 27, 2025
Copy link
Collaborator

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. will open debt issue to move that blob gas used check into a new jovian model, not a prio now though in order to unblock.

@mattsse mattsse added this pull request to the merge queue Oct 27, 2025
Merged via the queue into paradigmxyz:main with commit f9c89a9 Oct 27, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants