fix enum typing from _lib #62145
Open
fix enum typing from _lib #62145
+81
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 19, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
sterliakov
reviewed
Aug 29, 2025
| @@ -1435,11 +1435,11 @@ def _range_from_fields( | |||
| if quarter is not None: | |||
| if freq is None: | |||
| freq = to_offset("Q", is_period=True) | |||
| base = FreqGroup.FR_QTR.value | |||
| base = cast(int, FreqGroup.FR_QTR.value) | |||
There was a problem hiding this comment.
Note that this is a mypy bug and is no longer necessary on mypy master (python/mypy#19352), so the next release will cause [redundant-cast] here and below
There was a problem hiding this comment.
Yes. I made the changes in this PR to address the future mypy, but we need the code to work now with the current mypy and so that the changes made in the dev version of mypy work with pandas.
sterliakov
reviewed
Aug 29, 2025
| @@ -74,6 +74,44 @@ | |||
| "pandas._libs.tslibs.offsets.BusinessHour.rollforward ", | |||
| # type alias | |||
| "pandas._libs.tslibs.timedeltas.UnitChoices", | |||
| # enum types in cython vs PYI | |||
| "pandas._libs.tslibs.dtypes.FreqGroup.FR_ANN", | |||
There was a problem hiding this comment.
Even better, that same PR made all these entries redundant as well - current stubtest on mypy master does not report them as incompatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypyis fixing how they handleenumtypes, and the fix revealed an issue with how we handle them.See python/mypy#19687 (comment)