TST GH26807 Break up test_strings #39215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Testing
Contributor
|
thanks @moink |
nofarm3
pushed a commit
to nofarm3/pandas
that referenced
this pull request
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses xref #26807 in the case of pandas/tests/test_strings.py. It deletes that file and makes a new subpackage pandas/tests/strings/ with 8 new test modules plus a conftest file.
I have only moved tests and flattened the structure by moving the tests from being methods to functions - I haven't changed them in any other way. There are 1814 tests that were in pandas/tests/test_strings.py and are now in pandas/tests/strings/. I tried to keep each test module logically cohesive and less than 1000 lines long - test_strings.py still contains all the tests that don't really fit anywhere else.