Fix string literals escaping logic #122
Open
+18
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stringLiteralWithQuotes
had some leftover Kotlin string escaping logic that had to be cleaned up:$
→${'$'}
– thisbreaks emitting the intended string literal.
.trimMargin
doesn’t exist for Swift multiline strings, so the code would fail to compile ifwe attempted something like that.
Not
Before:
€\t@\t${'$'}
->"€\\t@\\t${'$'}{'${'$'}'}"
"\"ab$c();\\ndef();\""
->"\"ab${'$'}c();\\ndef();\""
After:
€\t@\t${'$'}
->"€\\t@\\t${'$'}"
"\"ab$c();\\ndef();\""
->"\"ab$c();\\ndef();\""