Skip to content

✨ Add zizmor to permissions allowlist #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −5
Open

✨ Add zizmor to permissions allowlist #4758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/slsa-goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ on:

permissions: read-all

env:
GO_VERSION: 1.24

jobs:
# Generate ldflags dynamically.
args:
Expand All @@ -34,7 +31,7 @@ jobs:
needs: args
uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected] #7f4fdb871876c23e455853d694197440c5a91506
with:
go-version: ${{ env.GO_VERSION }}
go-version: '1.24'
evaluated-envs: "VERSION_LDFLAGS:${{needs.args.outputs.ldflags}}"

verification:
Expand Down
2 changes: 1 addition & 1 deletion checks/permissions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func TestGithubTokenPermissions(t *testing.T) {
Score: checker.MaxResultScore,
NumberOfWarn: 0,
NumberOfInfo: 2, // This is constant.
NumberOfDebug: 8, // This is 4 + (number of actions)
NumberOfDebug: 9, // This is 4 + (number of actions)
},
},
{
Expand Down
4 changes: 4 additions & 0 deletions checks/raw/permissions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,10 @@ func isAllowedWorkflow(workflow *actionlint.Workflow, fp string, pdata *permissi
// Code scanning with HLint uploads a SARIF file to GitHub.
// https://github.com/haskell-actions/hlint-scan
"haskell-actions/hlint-scan": true,

// Code scanning with zizmor uploads a SARIF file to GitHub.
// https://github.com/zizmorcore/zizmor-action
"zizmorcore/zizmor-action": true,
}

tokenPermissions := checker.TokenPermission{
Expand Down
7 changes: 7 additions & 0 deletions checks/testdata/.github/workflows/github-workflow-permissions-secevent-known-actions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,10 @@ jobs:
security-events: write
steps:
- uses: haskell-actions/hlint-scan@v1

zizmorcore-zizmor:
runs-on: ubuntu-latest
permissions:
security-events: write
steps:
- uses: zizmorcore/[email protected]
Loading