-
Notifications
You must be signed in to change notification settings - Fork 565
✨ Add zizmor to permissions allowlist #4758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds zizmorcore/zizmor-action
to the allowlist of GitHub Actions that are permitted to use security-events: write
permission without triggering a security warning. The action performs code scanning and uploads SARIF files to GitHub, which legitimately requires this permission.
- Adds
zizmorcore/zizmor-action
to the allowlist in the permissions checker - Includes test case to verify the action is properly allowed
- Follows the same pattern as existing security scanning tools like hlint-scan
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
checks/raw/permissions.go | Adds zizmor-action to the allowlist of actions permitted to use security-events write permission |
checks/testdata/.github/workflows/github-workflow-permissions-secevent-known-actions.yaml | Adds test case for zizmor-action to verify it doesn't trigger security warnings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4758 +/- ##
==========================================
+ Coverage 66.80% 68.30% +1.49%
==========================================
Files 230 249 +19
Lines 16602 18929 +2327
==========================================
+ Hits 11091 12929 +1838
- Misses 4808 5137 +329
- Partials 703 863 +160 🚀 New features to boost your workflow:
|
- Add zizmor to permissions allowlist. - Fix workflow error. Signed-off-by: martincostello <[email protected]>
82ae86d
to
e990802
Compare
This pull request has been marked stale because it has been open for 10 days with no activity |
Awaiting review. |
What kind of change does this PR introduce?
Add
zizmorcore/zizmor-action
as an action that does not trigger a warning for use ofsecurity-events: write
.What is the current behavior?
Using the action generates a finding similar to the below:
What is the new behavior (if this is a feature change)?**
No finding is generated for use of
security-events: write
in a job that useszizmorcore/zizmor-action
.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
None.
Does this PR introduce a user-facing change?