hack: instanciate node with no name and id as short name #21
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Greiner <[email protected]>
Member
|
I'm not a huge fan of exposing IDs to the user, but a proper way to fix this would be more involved. We still trip over when the user renames a node to a trigram already used by another node. |
Collaborator
Author
|
I agree the fix is not clean at all and should be temporary. Anyway, this could temporary help users to use the macro view with less bugs What do you think @maelysLeratRosso of having such a fix, since a solid feature will fix this anyway in the few weeks/months? |
|
What do the ids look like ? |
Member
|
In NGE, IDs are arbitrary monotonically increasing integers. This PR would set default trigrams to e.g. |
|
Ok so temporarily it seems ok ? id42 is not too ugly |
Collaborator
Author
Enregistrement.de.l.ecran.2025-11-19.115033.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close OpenRailAssociation/osrd#13869