inode utilisiation option is added to disk metrics. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osiegmar
requested changes
Jan 28, 2017
Owner
osiegmar
left a comment
osiegmar
left a comment
There was a problem hiding this comment.
Thanks for your work! Please check my review comments.
| disks.append(Disk(mount, file_system, total, used, avail)) | ||
| disks.append(Disk(mount, file_system, total, used, avail, 0)) | ||
|
|
||
| df_inode_out = [s.split() for s in |
Owner
There was a problem hiding this comment.
Could you please only gather inode usage if it was requested via CLI argument?
| disk_group.add_argument('--disk-space-avail', | ||
| action='store_true', | ||
| help='Reports available disk space in gigabytes.') | ||
| disk_group.add_argument('--disk-inode-util', |
Owner
There was a problem hiding this comment.
Please move this below the disk-space block (below the disk-space-units)
Author
|
Thanks for the review. |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time we face "No space left on device" issue, although there is space on disk. The problem is directly related to 100% inode usage. So we need to monitor inode utilisation on instances too.
"df" command is able to give block storage or inode statistics according to "-i" parameter. So I executed df command twice to get both of those data. 2 additional iterations are added to get_disk_info method. The first one works as-is by adding inode_util value as 0. The second iteration calculates inode usage and puts this value on a temp list. The third iteration aggregates two lists.