-
Notifications
You must be signed in to change notification settings - Fork 858
dhcp/kea: Install prefix delegation routes targeting IA_NA address #9306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Monviech
wants to merge
8
commits into
master
Choose a base branch
from
kea-prefixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+156
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4b1f9a to
a24272e
Compare
fichtner
reviewed
Oct 24, 2025
fichtner
reviewed
Oct 24, 2025
fichtner
reviewed
Oct 24, 2025
fichtner
reviewed
Oct 24, 2025
fichtner
reviewed
Oct 24, 2025
fichtner
reviewed
Oct 24, 2025
fichtner
reviewed
Oct 24, 2025
fichtner
reviewed
Oct 24, 2025
|
|
||
| /* delete and re-add routes */ | ||
| foreach ($routes as $prefix => $address) { | ||
| mwexecf('/sbin/route delete -inet6 %s', [$prefix], true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could avoid the delete and add, but we’d need to check if it exists for semantics reasons in ifconfig. Maybe later, not for now.
fichtner
approved these changes
Oct 24, 2025
|
@AdSchellevis I wait for your ok before merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9135
This uses the same logic and reuses most code of the existing
prefixes.phpandprefixes.sh.I tested it and it works on my box that has a static delegated prefix from my ISP, the service also works after a reboot.
The lease files are synchronized between primary and secondary kea nodes in HA, meaning both will install the same static routes.
A static route can only be installed if there is an interface with an IPv6 address in the same prefix as the gateway address (IA_NA) of the IA_PD.
This means currently there is no support for LLA routes, as we do not want to assume anything. IA_NA and IA_PD are both in the lease file == zero assumptions.
Theoretically if one would use KEA hooks, there is an env variable with the LLA of the requesting client, which could theoretically be used for routing, if one would be bold enough to trust KEAs hooks.