Skip to content

[66939] Failed update re-rendered the entire component #20065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

[66939] Failed update re-rendered the entire component #20065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfd7adb
Make the render a stream update
mereghost Aug 27, 2025
8008cc5
Disable rubocop for the update action
mereghost Aug 27, 2025
2e9b2e9
Updates test
mereghost Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/controllers/admin/custom_fields/hierarchy/items_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def create
)
end

# rubocop:disable Metrics/AbcSize
def update
input = item_input
item_service
Expand All @@ -86,15 +87,15 @@ def update
short: input[:short],
score: input[:score])
.either(
lambda do |_|
redirect_to(custom_field_item_path(@custom_field, @active_item.parent), status: :see_other)
end,
->(*) { redirect_to(custom_field_item_path(@custom_field, @active_item.parent), status: :see_other) },
lambda do |validation_result|
add_errors_to_edit_form(validation_result)
render action: :edit
update_via_turbo_stream(component: ItemComponent.new(item: @active_item, show_edit_form: true))
respond_with_turbo_streams
end
)
end
# rubocop:enable Metrics/AbcSize

def move
item_service
Expand Down
14 changes: 10 additions & 4 deletions spec/controllers/admin/custom_fields/hierarchy/items_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,16 @@
end

context "when validation fails" do
it "renders the new page" do
post :update, params: { custom_field_id: custom_field.id, id: luke.id, label: nil }
expect(response).to be_successful
expect(response).to render_template "edit"
before do
allow(controller).to receive(:respond_with_turbo_streams).and_call_original
allow(controller).to receive(:add_errors_to_edit_form).and_call_original
end

it "renders the errors on the page" do
post :update, params: { custom_field_id: custom_field.id, id: luke.id, label: nil, format: :turbo_stream }

expect(controller).to have_received(:respond_with_turbo_streams).once
expect(controller).to have_received(:add_errors_to_edit_form).once
end
end
end
Expand Down
Loading