Skip to content

cmd/operator-sdk: fix run local flags #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2020
Merged

cmd/operator-sdk: fix run local flags #2478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
575573a
cmd/operator-sdk: fix run local flags (fixes #2477)
liranp Jan 28, 2020
d605009
CHANGELOG.md: update for next release
liranp Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
### Bug Fixes

- Fixed issue with Go dependencies caused by removed tag in `openshift/api` repository ([#2466](https://github.com/operator-framework/operator-sdk/issues/2466))
- Fixed a regression in the `operator-sdk run` command that caused `--local` flags to be ignored ([#2478](https://github.com/operator-framework/operator-sdk/issues/2478))

## v0.15.0

Expand Down
2 changes: 1 addition & 1 deletion cmd/operator-sdk/run/local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type runLocalArgs struct {
helmOperatorFlags *hoflags.HelmOperatorFlags
}

func (c runLocalArgs) addToFlags(fs *pflag.FlagSet) {
func (c *runLocalArgs) addToFlags(fs *pflag.FlagSet) {
prefix := "[local only] "
fs.StringVar(&c.operatorFlags, "operator-flags", "",
prefix+"The flags that the operator needs. Example: \"--flag1 value1 --flag2=value2\"")
Expand Down