-
Notifications
You must be signed in to change notification settings - Fork 68
Description
While reviewing the makefile I noticed several potential issues:
-
The
installtarget, which does not build anything depends on thegeneratetarget which invokescontroller-gento updateDeepCopy, DeepCopyInfo andDeepCopyObjectmethods. Thegeneratecommand _should_ probably be a dependency ofbuild-linuxorbuild`. -
The
installtarget does not allow for specifying anyIMG, so it assumes the default image name. Thedeploytarget can be used to install -
The
uninstalltarget removes CRDs, but theinstalltarget installs everything (and is used byrun). -
The
deploytarget installs the controller, theundeploytarget removes everything. (This is OK.) -
The
quickstarttarget creates a manifest (operator-controller.yaml), but ignores it in favor of a released version.