chore: josdk version to 4.2.7 #32
Conversation
| } | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| private void setControllerOverrides(ControllerConfigurationOverrider<?> o, |
There was a problem hiding this comment.
Thinking more about it, the starter should either reuse an implementation of ControllerConfiguration or provide its own instead of relying on overriding.
There was a problem hiding this comment.
Why? I think this is much more elegant, basically that is what you want to do, override the defaults by providing properties.
There was a problem hiding this comment.
Ideally starter is just a wrapper, we should avoid having custom implementations if not really needed.
There was a problem hiding this comment.
It looks more elegant but is wrong as the resource type shouldn't be changed from what the Reconciler implementation defines.
There was a problem hiding this comment.
We can emit resource type, and add it if somebody asks for it. And see the reasons.
No description provided.