Error status handler improvements #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
reviewed
Dec 8, 2021
| when(configService.getResourceCloner()).thenReturn(ConfigurationService.DEFAULT_CLONER); | ||
| when(reconciler.reconcile(eq(customResource), any())) | ||
| .thenReturn(UpdateControl.updateResource(customResource)); | ||
| when(configService.getResourceCloner()).thenReturn(new Cloner() { |
Collaborator
Author
There was a problem hiding this comment.
To make sure to make easier to do when(..).thenReturn() with mockito. Since otherwise its a different instance.
Collaborator
There was a problem hiding this comment.
Yes, but then you're not really testing the actual behavior?
Collaborator
Author
There was a problem hiding this comment.
This can be understood as a form of a mocking of that clone method / cloner. The goal here is not to test the cloner but only if it is called in case it's relevant.
Collaborator
There was a problem hiding this comment.
I understand but the problem is what if the behavior changes when the instance is not actually cloned?
Collaborator
Author
There was a problem hiding this comment.
Actually not, is just what instance we move around, for some special cases.
metacosm
reviewed
Dec 8, 2021
metacosm
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.