chore: renaming vars named k8sClient to kubernetsClient #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
approved these changes
Oct 6, 2021
metacosm
approved these changes
Oct 6, 2021
Collaborator
|
@iocanel please make your PRs modifiable by maintainers |
iocanel
force-pushed
the
align-client-naming
branch
from
4c94c81 to
636eb58
Compare
Collaborator
Author
I always forget it. Is there a way to change that by default? |
metacosm
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request renames instances of
k8sClienttokubernetesClient.This is done mostly to align naming across the board and to make our getters follow the standard conventions more accurately.