feat: improve workflow error reporting #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
csviri
reviewed
Nov 23, 2022
Collaborator
csviri
left a comment
csviri
left a comment
There was a problem hiding this comment.
Just one question / design decision to clarify other than that looks good.
| public class AggregatedOperatorException extends OperatorException { | ||
|
|
||
| private final List<Exception> causes; | ||
| private final Map<String, Exception> causes; |
Collaborator
There was a problem hiding this comment.
Why is the key String here? It could be DependentResource I guess.
Collaborator
Author
There was a problem hiding this comment.
The exception is not necessarily meant only for workflow errors so the key could be anything identifying "what" caused that specific error so that user has some idea of what's going on.
csviri
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.