Skip to content

Metrics #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2022
Merged

Metrics #1059

merged 2 commits into from
Mar 22, 2022

Conversation

@scrocquesel
Copy link
Contributor

@scrocquesel scrocquesel commented Mar 21, 2022

  • initContextIfNeeded should be part of total time execution.
  • some optimization to avoid resolving metrics instance for each call. It should be a singleton, so I guess it is safe to keep a reference on it. the instance can be fetch from configuration.getConfigurationService() but a lot of unit tests are stubbing ConfigurationServiceProvider.instance() instead.

csviri
csviri approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

metacosm
metacosm approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit baf94e7 into operator-framework:next Mar 22, 2022
@scrocquesel scrocquesel deleted the metrics branch March 23, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metacosm metacosm metacosm approved these changes

@csviri csviri csviri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scrocquesel @metacosm @csviri