Skip to content

fix: unit flaky tests #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022
Merged

fix: unit flaky tests #1032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions ...k-core/src/test/java/io/javaoperatorsdk/operator/processing/event/EventProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
import org.mockito.internal.stubbing.answers.AnswersWithDelay;
import org.mockito.internal.stubbing.answers.Returns;
import org.mockito.stubbing.Answer;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -24,14 +26,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.ArgumentMatchers.isNull;
import static org.mockito.Mockito.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;

class EventProcessorTest {

Expand All @@ -40,6 +35,7 @@ class EventProcessorTest {
public static final int FAKE_CONTROLLER_EXECUTION_DURATION = 250;
public static final int SEPARATE_EXECUTION_TIMEOUT = 450;
public static final String TEST_NAMESPACE = "default-event-handler-test";

private ReconciliationDispatcher reconciliationDispatcherMock =
mock(ReconciliationDispatcher.class);
private EventSourceManager eventSourceManagerMock = mock(EventSourceManager.class);
Expand Down Expand Up @@ -188,24 +184,27 @@ void scheduleTimedEventIfInstructedByPostExecutionControl() {
}

@Test
void reScheduleOnlyIfNotExecutedEventsReceivedMeanwhile() {
void reScheduleOnlyIfNotExecutedEventsReceivedMeanwhile() throws InterruptedException {
var testDelay = 10000L;
when(reconciliationDispatcherMock.handleExecution(any()))
.thenReturn(PostExecutionControl.defaultDispatch().withReSchedule(testDelay));

eventProcessor.handleEvent(prepareCREvent());
eventProcessor.handleEvent(prepareCREvent());

verify(retryTimerEventSourceMock, timeout(SEPARATE_EXECUTION_TIMEOUT).times(0))
.scheduleOnce(any(), eq(testDelay));
doAnswer(new AnswersWithDelay(FAKE_CONTROLLER_EXECUTION_DURATION,
new Returns(PostExecutionControl.defaultDispatch().withReSchedule(testDelay))))
.when(reconciliationDispatcherMock).handleExecution(any());
var resourceId = new ResourceID("test1", "default");
eventProcessor.handleEvent(prepareCREvent(resourceId));
Thread.sleep(FAKE_CONTROLLER_EXECUTION_DURATION / 3);
eventProcessor.handleEvent(prepareCREvent(resourceId));

verify(retryTimerEventSourceMock,
after((long) (FAKE_CONTROLLER_EXECUTION_DURATION * 1.5)).times(0))
.scheduleOnce(any(), eq(testDelay));
}

@Test
void doNotFireEventsIfClosing() {
eventProcessor.stop();
eventProcessor.handleEvent(prepareCREvent());

verify(reconciliationDispatcherMock, timeout(50).times(0)).handleExecution(any());
verify(reconciliationDispatcherMock, after(50).times(0)).handleExecution(any());
}

@Test
Expand Down