feat: dependent resource inherits namespaces from controller config #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Mar 10, 2022
Collaborator
metacosm
left a comment
metacosm
left a comment
There was a problem hiding this comment.
I'm OK with the change but that is a breaking change that will impact users (they will have to change their reconciler implementations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary objective was to inherit the default namespace to the dependent informers if not configured explicitly (standalone).
For the we need the
ControllerConfigurationnotConfigurationService( but that is accessible from controller config). So unified also the contexts to provide the controller configuration instead of configuration service. (This part is optional)