Skip to content

Conversation

laxmikantbpandhare
Copy link
Member

Added below changes in pom.xml file

    <dependency>
      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-micrometer-registry-prometheus</artifactId>
      <version>${quarkus.version}</version>
    </dependency>

It will expose the metrics endpoints

@laxmikantbpandhare laxmikantbpandhare linked an issue Nov 19, 2021 that may be closed by this pull request
@metacosm
Copy link
Collaborator

I don't think that we should be making this change. It's up to users to decide how they want their metrics to be published.

@laxmikantbpandhare
Copy link
Member Author

laxmikantbpandhare commented Nov 19, 2021

I don't think that we should be making this change. It's up to users to decide how they want their metrics to be published.

@metacosm - So, does that mean, we should not update the plugin and let the user know that they can use this feature? Then, we can update the tutorial accordingly.

@metacosm
Copy link
Collaborator

This can be shown as part of the tutorial and/or examples but I don't think it should be part of the code generated by the plug-in.

@laxmikantbpandhare
Copy link
Member Author

This can be shown as part of the tutorial and/or examples but I don't think it should be part of the code generated by the plug-in.

Got your point. Thank you.

@metacosm
Copy link
Collaborator

Closing this.

@metacosm metacosm closed this Nov 23, 2021
@laxmikantbpandhare
Copy link
Member Author

Closing this.

@metacosm - We were discussing the possible inclusion of the metrics part. I had word with @jmrodri, we enable metrics by default with our SDK. So it seems natural we do the same thing with Java projects.

We are planning to enable the Metrics by default.

@metacosm
Copy link
Collaborator

Metrics are enabled by default. You just need to provide a metrics provider. Which metrics provider is used should be up to the user. Do go operators automatically expose things over Prometheus?

@laxmikantbpandhare
Copy link
Member Author

Metrics are enabled by default. You just need to provide a metrics provider. Which metrics provider is used should be up to the user. Do go operators automatically expose things over Prometheus?

yes.

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@laxmikantbpandhare laxmikantbpandhare merged commit 9217cc1 into operator-framework:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Micrometer Metrics from java-operator-sdk
3 participants