Query memory attributes in UCT #6306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@yosefe This is how the new API might look like. It will have a lot of overlap with the existing uct_md_mem_query(). |
SeyedMir
force-pushed
the
topic/uct_mem_attr
branch
4 times, most recently
from
08b7fa1 to
6bb4a80
Compare
SeyedMir
force-pushed
the
topic/uct_mem_attr
branch
2 times, most recently
from
5310e78 to
7262d42
Compare
SeyedMir
force-pushed
the
topic/uct_mem_attr
branch
from
7262d42 to
eec86cc
Compare
SeyedMir
changed the title
Unlike the existing uct_md_mem_query(), then new API is not specific to a single MD. Therefore, it does not need a handle to an opened MD.
SeyedMir
force-pushed
the
topic/uct_mem_attr
branch
from
eec86cc to
2f676ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds an internal UCT service to query memory attributes.
Why ?
Currently, we cannot query memory attributes of a given pointer at UCT layer. The existing uct_md_mem_query()
requires a handle to an MD and queries the attributes only from that MD.
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.