-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Create builder for TransitDataProviderFilter #6974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create builder for TransitDataProviderFilter #6974
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6974 +/- ##
=============================================
+ Coverage 72.14% 72.20% +0.05%
- Complexity 19772 19866 +94
=============================================
Files 2151 2156 +5
Lines 79955 80091 +136
Branches 8058 8084 +26
=============================================
+ Hits 57687 57827 +140
+ Misses 19423 19419 -4
Partials 2845 2845 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[Refactor] ? |
...r/routing/algorithm/raptoradapter/transit/request/RouteRequestTransitDataProviderFilter.java
Show resolved
Hide resolved
9cca964 to
928bdee
Compare
|
Edit: Changed the commit messages to use "refactor:" instead of "[Refactor]". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification!
This is not documented in the api. But in order to not change behavior an empty filter list in the request should discard everything.
|
I noticed a slight change in behavior. An explicitly empty filter list in the request would originally disallow all transit. This behavior is undocumented and differs from what we usually do. In order to not break any clients in the event that they are depending on this I fixed it and added a test. |
4ff26ea
into
opentripplanner:dev-2.x
Summary
This PR is a small refactor of the
RouteRequestTransitDataProviderFilter. It doesn't change any behavior at all.RouteRequest.DefaultTransitDataProviderFilter.Unit tests
No new unit tests are added, but the builder makes a lot of tests much more readable.
Documentation
None needed IMO
Bumping the serialization version id
Nope