Skip to content

Simplify equals in TripPatternForDate #6883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Simplify equals in TripPatternForDate #6883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .../java/org/opentripplanner/routing/algorithm/raptoradapter/transit/TripPatternForDate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ public int hashCode() {

/**
* The natural key of a TripPatternForDate is the pair (routing trip pattern id, service date).
* TODO: align equals and hashcode to use only the pair (routing trip pattern id, service date)
*/
@Override
public boolean equals(Object o) {
Expand All @@ -180,12 +179,7 @@ public boolean equals(Object o) {
}
TripPatternForDate that = (TripPatternForDate) o;

return (
tripPattern.equals(that.tripPattern) &&
serviceDate.equals(that.serviceDate) &&
Arrays.equals(tripTimes, that.tripTimes) &&
Arrays.equals(frequencies, that.frequencies)
);
return (tripPattern.equals(that.tripPattern) && serviceDate.equals(that.serviceDate));
}

@Override
Expand Down
2 changes: 0 additions & 2 deletions ...ication/src/test/java/org/opentripplanner/routing/algorithm/mapping/SnapshotTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import static au.com.origin.snapshots.SnapshotMatcher.expect;
import static java.time.format.DateTimeFormatter.ISO_LOCAL_TIME;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;

import au.com.origin.snapshots.serializers.SerializerType;
import au.com.origin.snapshots.serializers.SnapshotSerializer;
Expand Down
Loading