Skip to content

Conversation

@leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Sep 9, 2025

Summary

It fixes a strange edge case where repeated times in the schedule lead to an inability to SKIP stops with a GTFS-RT TripUpdate.

Issue

Closes #6848

Unit tests

A module test was added.

Documentation

Javadoc.

cc @laurentg

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner September 9, 2025 12:56
@leonardehrenfried leonardehrenfried added !Bug Apply to issues describing a bug and PRs witch fixes it. +Real-Time The issue/PR is related to RealTime updates labels Sep 9, 2025
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.08%. Comparing base (a4136ad) to head (48ff0a4).
⚠️ Report is 94 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6849   +/-   ##
==========================================
  Coverage      72.08%   72.08%           
- Complexity     19517    19518    +1     
==========================================
  Files           2105     2105           
  Lines          78976    78977    +1     
  Branches        8007     8007           
==========================================
+ Hits           56930    56931    +1     
+ Misses         19228    19227    -1     
- Partials        2818     2819    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miklcct miklcct self-assigned this Sep 9, 2025
@t2gran t2gran added this to the 2.9 (next release) milestone Sep 10, 2025
@miklcct
Copy link
Contributor

miklcct commented Sep 10, 2025

Thanks. Can't see any problem with your approach as the scheduled diff is always 0 in this case for the cancelled stops, so the interpolated times are always the same as the previous non-cancelled stop.

@leonardehrenfried leonardehrenfried merged commit 314275c into opentripplanner:dev-2.x Sep 11, 2025
7 checks passed
t2gran pushed a commit that referenced this pull request Sep 11, 2025
@leonardehrenfried leonardehrenfried deleted the skipped-repeated-times branch September 12, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it. +Real-Time The issue/PR is related to RealTime updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelling a stop with GTFS-RT fails when the scheduled stop times are repeating

4 participants