- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.1k
 
Remove GTFS "remove repeated stops" feature #6846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GTFS "remove repeated stops" feature #6846
Conversation
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@              Coverage Diff              @@
##             dev-2.x    #6846      +/-   ##
=============================================
+ Coverage      72.00%   72.07%   +0.06%     
- Complexity     19430    19507      +77     
=============================================
  Files           2099     2105       +6     
  Lines          78730    78936     +206     
  Branches        7961     8000      +39     
=============================================
+ Hits           56692    56890     +198     
+ Misses         19233    19230       -3     
- Partials        2805     2816      +11     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one small thing, otherwise good!
Summary
It removes the feature to remove repeated stops from the GTFS processing.
Background
In GTFS Flex feeds it is often required that you have two consecutive stop times with the same stop location but this feature removes one of them, leading to strange API results. (The flex code itself had already ignored the repetition).
I at first wanted to add a special case for flex but then thought that we probably never want to "fix" input data. A quick chat with @optionsome confirms this. For that reason I'm removing the feature altogether.
Note: NeTEx already disables this feature permanently.
Issue
None.
Unit tests
n/a
Documentation
Removed.