Skip to content

Conversation

@leonardehrenfried
Copy link
Member

Summary

It removes the feature to remove repeated stops from the GTFS processing.

Background

In GTFS Flex feeds it is often required that you have two consecutive stop times with the same stop location but this feature removes one of them, leading to strange API results. (The flex code itself had already ignored the repetition).

I at first wanted to add a special case for flex but then thought that we probably never want to "fix" input data. A quick chat with @optionsome confirms this. For that reason I'm removing the feature altogether.

Note: NeTEx already disables this feature permanently.

Issue

None.

Unit tests

n/a

Documentation

Removed.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner September 8, 2025 08:32
@leonardehrenfried leonardehrenfried added +GTFS Related to import of GTFS data !Technical Debt Improve code quality, no functional changes. labels Sep 8, 2025
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.07%. Comparing base (1c8fdcb) to head (cbedeab).
⚠️ Report is 112 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6846      +/-   ##
=============================================
+ Coverage      72.00%   72.07%   +0.06%     
- Complexity     19430    19507      +77     
=============================================
  Files           2099     2105       +6     
  Lines          78730    78936     +206     
  Branches        7961     8000      +39     
=============================================
+ Hits           56692    56890     +198     
+ Misses         19233    19230       -3     
- Partials        2805     2816      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

optionsome
optionsome previously approved these changes Sep 8, 2025
Copy link
Contributor

@jessicaKoehnke jessicaKoehnke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small thing, otherwise good!

@leonardehrenfried leonardehrenfried merged commit 0e2fab3 into opentripplanner:dev-2.x Sep 10, 2025
8 checks passed
@leonardehrenfried leonardehrenfried deleted the remove-repeated-stops branch September 10, 2025 15:42
t2gran pushed a commit that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+GTFS Related to import of GTFS data !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants