Skip to content

Conversation

@leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Mar 1, 2023

Summary

This one adds the new FaresV2 entities to the GraphQL API.

I would like to talk about the schema in the dev meeting if it is the right way to think about fares.

Closes #4935

Unit tests

Added.

@leonardehrenfried leonardehrenfried added !Improvement A functional improvement or micro feature +Sandbox This will be implemented as a Sandbox feature IBI Developed by or important for IBI Group labels Mar 1, 2023
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner March 1, 2023 11:21
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 89.21% and project coverage change: +0.11 🎉

Comparison is base (e7b48eb) 64.46% compared to head (b19f553) 64.58%.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4917      +/-   ##
=============================================
+ Coverage      64.46%   64.58%   +0.11%     
- Complexity     13896    13937      +41     
=============================================
  Files           1721     1725       +4     
  Lines          67229    67355     +126     
  Branches        7214     7218       +4     
=============================================
+ Hits           43339    43499     +160     
+ Misses         21466    21435      -31     
+ Partials        2424     2421       -3     
Impacted Files Coverage Δ
...nner/ext/fares/impl/AddingMultipleFareService.java 0.00% <ø> (-85.19%) ⬇️
...r/ext/fares/impl/CombinedInterlinedTransitLeg.java 52.00% <0.00%> (-4.53%) ⬇️
...nner/ext/fares/impl/DefaultFareServiceFactory.java 86.04% <ø> (ø)
...entripplanner/ext/fares/impl/GtfsFaresService.java 85.71% <ø> (ø)
...tripplanner/ext/fares/impl/GtfsFaresV2Service.java 95.96% <0.00%> (ø)
...planner/ext/fares/impl/NoopFareServiceFactory.java 0.00% <ø> (ø)
...ipplanner/ext/fares/impl/SFBayFareServiceImpl.java 0.00% <ø> (ø)
.../fares/impl/TimeBasedVehicleRentalFareService.java 0.00% <ø> (ø)
...opentripplanner/ext/fares/model/FareRulesData.java 100.00% <ø> (ø)
...g/opentripplanner/ext/flex/FlexibleTransitLeg.java 40.00% <0.00%> (-1.94%) ⬇️
... and 37 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leonardehrenfried leonardehrenfried force-pushed the fares-v2-graphql branch 2 times, most recently from e588013 to db108e5 Compare March 1, 2023 15:57
@leonardehrenfried leonardehrenfried marked this pull request as draft March 3, 2023 17:52
@t2gran t2gran added this to the 2.3 milestone Mar 14, 2023
@leonardehrenfried leonardehrenfried force-pushed the fares-v2-graphql branch 9 times, most recently from 80cf74a to c08be0f Compare March 24, 2023 14:24
@leonardehrenfried leonardehrenfried changed the title Add fares v2 API to GraphQL API Add fares v2 to GraphQL API Mar 24, 2023
@leonardehrenfried leonardehrenfried force-pushed the fares-v2-graphql branch 5 times, most recently from d0f459f to 1e38b14 Compare March 27, 2023 13:29
@leonardehrenfried leonardehrenfried marked this pull request as ready for review March 27, 2023 20:35
@leonardehrenfried leonardehrenfried marked this pull request as draft March 28, 2023 08:35
vesameskanen
vesameskanen previously approved these changes Apr 28, 2023
@leonardehrenfried
Copy link
Member Author

@vesameskanen has already approved this twice so I'm going wait to re-request a review until @t2gran has finished his review.

@t2gran
Copy link
Member

t2gran commented May 2, 2023

I am done with my review now. I have not reviewed the classes inside the Sandbox and only done a technical review on the rest. I do not now the GTFS Fares spec so my review on the business logic is at best superficial.

@leonardehrenfried leonardehrenfried requested a review from t2gran May 3, 2023 11:17
@leonardehrenfried
Copy link
Member Author

We discussed this in the dev meeting today and I've renamed validityDuration to validity.

@leonardehrenfried leonardehrenfried merged commit 2dd9417 into opentripplanner:dev-2.x May 8, 2023
t2gran pushed a commit that referenced this pull request May 8, 2023
@leonardehrenfried leonardehrenfried deleted the fares-v2-graphql branch July 18, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IBI Developed by or important for IBI Group !Improvement A functional improvement or micro feature +Sandbox This will be implemented as a Sandbox feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New fares for GraphQL API

4 participants