Stylus is broken in the last Chrome canary

[vsemozhetbyt]

• Browser: Google Chrome 72.0.3592.0 (Official Build) canary (64-bit)
• Operating System: Windows 7 x64

Styles list in the manage.html is empty. There is an error in the console:

Uncaught (in promise) TypeError: Cannot read property 'name' of null
    at sorter.sort.styles.styles.map.style (manage.js:122)
    at Array.map (<anonymous>)
    at showStyles (manage.js:120)
    at Promise.all.then.args (manage.js:39)

The same error after an attempt to create and save a new style and go back to manage page. The style is not shown, the list is still empty.

[vsemozhetbyt]

Error in the "Inspect views - background page":

Uncaught (in promise) TypeError: Cannot read property 'id' of null
    at dbExec.then.event (storage.js:179)

[eight04]

@Mottie I think we have to investigate why there is a null value inside the array to fix this bug.

[eight04]

@vsemozhetbyt Have you done something before the manager becomes empty?

[emeryao]

+1
same here with chrome 72.0.3592.0 canary 64bit

[vsemozhetbyt]

@eight04 No, nothing at all. Canary has just updated and stylus has broken.

[eight04]

Open manage.html and try executing these commands in the dev console:

1. BG.dbExec - this should report a function name, which should be dbExecIndexedDB or dbExecChromeStorage.
2. copy(BG.cachedStyles.list) - this would copy all styles to the clipboard. It would also help if you can post them here.

[vsemozhetbyt]

@eight04

> BG.dbExec
< ƒ dbExecIndexedDB(method, ...args) {
  return new Promise((resolve, reject) => {
    Object.assign(indexedDB.open('stylish', 2), {
      onsuccess(event) {
        const database = event.target.result;…
> copy(BG.cachedStyles.list)
< undefined

Copied BG.cachedStyles.list (the first 4 null seems to be my disappeared styles, the 5th object seems to be the last attempt to save a new style which is not shown in the list though):

[
  null,
  null,
  null,
  null,
  {
    "enabled": true,
    "updateUrl": null,
    "md5Url": null,
    "url": null,
    "originalMd5": null,
    "installDate": 1540555811467,
    "name": "global",
    "sections": [
      {
        "code": ":link, :link * {color: blue !important;}\n:visited, :visited * {color: red !important;}\n\n:link img {outline: 1px solid white !important;}\n:visited img {outline: 1px solid red !important;}\n\n:focus {outline: 1px solid blue !important;}\n",
        "urls": [],
        "urlPrefixes": [],
        "domains": [],
        "regexps": []
      }
    ],
    "id": 14
  }
]

[vsemozhetbyt]

I've opened manage.html and cleared the IndexedDB and the Local Storage in the DevTools Application tab. Then I've managed to create and save my styles. Now everything is OK.

[jonyroda97]

Same problem here. Executing the commands said above gives me:

> BG.dbExec
< ƒ dbExecIndexedDB(method, ...args) {
  return new Promise((resolve, reject) => {
    Object.assign(indexedDB.open('stylish', 2), {
      onsuccess(event) {
        const database = event.target.result;…
> copy(BG.cachedStyles.list)
< undefined

[
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null,
  null
]

[vsemozhetbyt]

To be clear: I had to manually recreate all my styles. It seems they were lost in an unrecoverable way if I am not mistaken. If you find the cause, maybe it is worth to report to the Chromium issue tracker to prevent such things in future, as many users would be hurt by this.

[vsemozhetbyt]

To be on the safe side: https://bugs.chromium.org/p/chromium/issues/detail?id=899446

[jonyroda97]

To be clear: I had to manually recreate all my styles. It seems they were lost in an unrecoverable way if I am not mistaken.

Same here