Skip to content

Conversation

@archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Nov 6, 2025

Consider code like this:

int x = 1;
x <<= 1L;

The compiler currently emits this warning:

warning: [lossy-conversions] implicit cast from long to int in compound assignment is possibly lossy
        x <<= 1L;
              ^

By definition, bit shift operations only use the bottom 5 or 6 bits of the specified shift amount (in this example, 1L), and the JLS does not require the shift amount to be any specific integral type, only that that it be some integral type. So as long all but the bottom 5 or 6 bits are zero, there is no loss of information and the warning is inappropriate.

The case where the bottom 5 or 6 bits are not all zero is addressed separately in JDK-5038439.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371162: Compiler warns about implicit cast from long to int in shift operation (Bug - P4)(⚠️ The fixVersion in this issue is [27] but the fixVersion in .jcheck/conf is 26, a new backport will be created when this pr is integrated.)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28180/head:pull/28180
$ git checkout pull/28180

Update a local copy of the PR:
$ git checkout pull/28180
$ git pull https://git.openjdk.org/jdk.git pull/28180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28180

View PR using the GUI difftool:
$ git pr show -t 28180

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28180.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2025

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@archiecobbs The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant