8362894: PKCS12 KeyStore PBMAC1 interoperability testing

[mpdonova]

With the integration of JDK-8343232, this PR updates the Keytool/OpenSSL interop test to include a test case using PBMAC1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362894: PKCS12 KeyStore PBMAC1 interoperability testing (Enhancement - P4)

Reviewers

• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28150/head:pull/28150
$ git checkout pull/28150

Update a local copy of the PR:
$ git checkout pull/28150
$ git pull https://git.openjdk.org/jdk.git pull/28150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28150

View PR using the GUI difftool:
$ git pr show -t 28150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28150.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362894: PKCS12 KeyStore PBMAC1 interoperability testing

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 259 new commits pushed to the master branch:

• 9ea8201: 8363980: [macos] Add JDK specific keys/values to Info.plist of embedded runtime
• 3949b0f: 8371674: C2 fails with Missed optimization opportunity in PhaseIterGVN for MoveL2D
• f0afd89: 8357728: Avoid caching synthesized names in synthesized parameters
• ... and 256 more: https://git.openjdk.org/jdk/compare/ef464d69399e50aee126a4756fe9a9a19e44d3c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mpdonova The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[myankelev]

nit: do you think it might be a good idea to bump the timeout by 10? As this command can take up to 10 seconds. Just to prevent future timeouts

[mlbridge]

Webrevs

• 01: Full - Incremental (dadded17)
• 00: Full (5dd38697)

[rhalade]

thanks for addressing this gap. Please update test test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java to include bug id 8343232 in @bug list.

[mpdonova]

/integrate

[openjdk]

Going to push as commit b3acc48.
Since your change was applied there have been 282 commits pushed to the master branch:

• de0a1f8: 8372277: Fix for JDK-8369517 is applied starting from source 24 instead of 26
• ea19ad2: 8347167: Reduce allocation in com.sun.net.httpserver.Headers::normalize
• 267ce91: 8372149: G1: Remove unnecessary num_added_to_group from G1CollectionSetCandidates::set_candidates_from_marking()
• ... and 279 more: https://git.openjdk.org/jdk/compare/ef464d69399e50aee126a4756fe9a9a19e44d3c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mpdonova Pushed as commit b3acc48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.