validation: fix nil deferences in cpu & blkio cgroups tests #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix several nil dereference errors in validation tests for cpu & blkio
cgroups, such as:
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x6eee8b]
goroutine 1 [running]:
github.com/opencontainers/runtime-tools/validation/util.ValidateLinuxResourcesBlockIO(0xc420264070,
0xc420248a50, 0x5, 0xc42027e540)
/home/vagrant/go/src/github.com/opencontainers/runtime-tools/validation/util/linux_resources_blkio.go:37 +0x2bb
github.com/opencontainers/runtime-tools/validation/util.RuntimeOutsideValidate(0xc4200102b0, 0x7c1c00, 0x0, 0x0)
/home/vagrant/go/src/github.com/opencontainers/runtime-tools/validation/util/test.go:279 +0x397
main.testEmptyBlkio(0x0, 0x0)
/home/vagrant/go/src/github.com/opencontainers/runtime-tools/validation/linux_cgroups_blkio.go:68 +0x19e
main.main()
/home/vagrant/go/src/github.com/opencontainers/runtime-tools/validation/linux_cgroups_blkio.go:88 +0x8c
```
Note that this PR fixes only a part of potential nil dereferences in
validation tests. It only touches cpu and blkio, which were discovered
during testing the PR
opencontainers#637.
Signed-off-by: Dongsu Park <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several nil dereference errors in validation tests for cpu & blkio cgroups, such as:
Note that this PR fixes only a part of potential nil dereferences in validation tests. It only touches cpu and blkio, which were discovered during testing the PR #637.
/cc @Mashimiao
Signed-off-by: Dongsu Park [email protected]