Skip to content

validate: modify the condition of the deviceValid #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2017
Merged

validate: modify the condition of the deviceValid #460

merged 1 commit into from
Sep 22, 2017

Conversation

@zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Sep 1, 2017

Accord to the mknod(1). We can get the following information:

Both MAJOR and MINOR must be specified when TYPE is b, c, or u, and they must be omitted when TYPE is p.

Signed-off-by: zhouhao [email protected]

@Mashimiao Mashimiao added this to the v0.2.0 milestone Sep 15, 2017
wking
wking approved these changes Sep 15, 2017
View reviewed changes
Copy link
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I may try and get this into the upstream JSON Schema later. And either way, unit tests for this would be good, although they don't need to block this PR.

@Mashimiao
Copy link

Mashimiao commented Sep 15, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@zhouhao3
Copy link
Author

zhouhao3 commented Sep 21, 2017

@hqhq @liangchenye PTAL

@liangchenye
Copy link
Member

liangchenye commented Sep 22, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@liangchenye liangchenye merged commit 0a52ac0 into opencontainers:master Sep 22, 2017
@zhouhao3 zhouhao3 deleted the devices-validate-fix branch September 25, 2017 02:37
wking added a commit to wking/ocitools-v2 that referenced this pull request Sep 25, 2017
@wking
CHANGELOG: Document changes since v0.1.0
694e0fe 
Through 0a52ac0 (Merge pull request opencontainers#460 from
q384566678/devices-validate-fix, 2017-09-22).

Signed-off-by: W. Trevor King <[email protected]>
@wking wking mentioned this pull request Sep 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zhouhao3 @Mashimiao @liangchenye @wking