Skip to content

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Mar 10, 2025

  • add codespell job, fix reported issues;
  • bump golangci-lint and golangci-lint-action to latest releases;
  • bump Go to supported versions (1.24.x, 1.25.x). (no longer included)

See individual commits for details.

@AkihiroSuda AkihiroSuda mentioned this pull request Sep 2, 2025
@AkihiroSuda
Copy link
Member

ping @kolyshkin

@kolyshkin kolyshkin changed the title Add codespell; bump CI deps CI: add codespell, bump golangci-lint, bump go Oct 10, 2025
@kolyshkin kolyshkin force-pushed the codespell branch 2 times, most recently from 83b32c4 to 4c838a8 Compare October 10, 2025 22:12
@kolyshkin kolyshkin requested a review from AkihiroSuda October 10, 2025 22:13
strategy:
matrix:
go: [1.21.x, 1.22.x]
go: [1.24.x, 1.25.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOTOOLCHAIN=local is needed to pin the Go version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this <lowest-version-supported>, oldstable, stable ? That also reduces the need to update versions (we'll continue testing some "lowest" version", and the other two test currently supported versions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See opencontainers/image-spec#1229 for an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me just remove the last commit so we can merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated; PTAL @sudo-bmitch @thaJeztah

@thaJeztah
Copy link
Member

Some spelling issues to fix;

./config-vm.md:78: conains ==> contains
./config-vm.md:78: minimun ==> minimum
./specs-go/config.go:691: containes ==> contains, container, contained
Error: Process completed with exit code 65.

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM (with linter errors fixed)

@kolyshkin kolyshkin changed the title CI: add codespell, bump golangci-lint, bump go CI: add codespell, bump golangci-lint Oct 14, 2025
@kolyshkin
Copy link
Contributor Author

Some spelling issues to fix;

./config-vm.md:78: conains ==> contains
./config-vm.md:78: minimun ==> minimum
./specs-go/config.go:691: containes ==> contains, container, contained
Error: Process completed with exit code 65.

Those are (relatively) new, from #1209. It's a pity that it was merged earlier than this PR.

Fixed now.

@kolyshkin
Copy link
Contributor Author

PTAL @sudo-bmitch @thaJeztah

@AkihiroSuda AkihiroSuda merged commit 3b11014 into opencontainers:main Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants