-
Notifications
You must be signed in to change notification settings - Fork 591
CI: add codespell, bump golangci-lint #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ping @kolyshkin |
83b32c4 to
4c838a8
Compare
.github/workflows/build.yml
Outdated
| strategy: | ||
| matrix: | ||
| go: [1.21.x, 1.22.x] | ||
| go: [1.24.x, 1.25.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOTOOLCHAIN=local is needed to pin the Go version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this <lowest-version-supported>, oldstable, stable ? That also reduces the need to update versions (we'll continue testing some "lowest" version", and the other two test currently supported versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See opencontainers/image-spec#1229 for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me just remove the last commit so we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated; PTAL @sudo-bmitch @thaJeztah
|
Some spelling issues to fix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM (with linter errors fixed)
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Those are (relatively) new, from #1209. It's a pity that it was merged earlier than this PR. Fixed now. |
|
PTAL @sudo-bmitch @thaJeztah |
bump Go to supported versions (1.24.x, 1.25.x).(no longer included)See individual commits for details.