Skip to content

Conversation

@giuseppe
Copy link
Member

commit 9d363b3 added the feature but
didn't update the json schema file.

Signed-off-by: Giuseppe Scrivano [email protected]

commit 9d363b3 added the feature but
didn't update the json schema file.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah. I wish there was a CI to block on missing schema coverage

@giuseppe
Copy link
Member Author

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need any changes for #1146, right?

@giuseppe
Copy link
Member Author

giuseppe commented May 2, 2022

This doesn't need any changes for #1146, right?

I think we should be fine. #1146 is just a fix for the Go library to make clear when the value was specified in the configuration.

In the example we have in config.md:

            "cpu": {
                "shares": 1024,
                "quota": 1000000,
                "period": 500000,
                "realtimeRuntime": 950000,
                "realtimePeriod": 1000000,
                "cpus": "2-3",
                "idle": 1,
                "mems": "0-7"
            },

idle has just the int64 value and it follows the schema update proposed here

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon tianon merged commit 2792412 into opencontainers:main May 5, 2022
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants