runc exec: fail with exit code of 255 #3073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure in centos7 is a glitch; restarted. |
AkihiroSuda
reviewed
Jul 12, 2021
exec.go
Outdated
| os.Exit(status) | ||
| } | ||
| return fmt.Errorf("exec failed: %w", err) | ||
| fatalWithCode(fmt.Errorf("exec failed: %w", err), -1) |
There was a problem hiding this comment.
Yes, it will probably look a tad better.
Fixed, PTAL @AkihiroSuda
There was a problem hiding this comment.
My bad. Let's try again
AkihiroSuda
previously approved these changes
Jul 12, 2021
AkihiroSuda
previously approved these changes
Jul 12, 2021
|
close/reopen to kick new cirrus ci |
|
OK, it's not working that way for cirrus-ci apparently, need to rebase. |
kolyshkin
force-pushed
the
runc-exec-255
branch
2 times, most recently
from
c4d0ff8 to
f926e36
Compare
Currently there's no way to distinguish between the two cases: - runc exec failed; - the command executed returned 1. This was possible before commit 8477638, as runc exec exited with the code of 255 if exec itself has failed. The code of 255 is the same convention as used by e.g. ssh. Re-introduce the feature, document it, and add some tests so it won't be broken again. Signed-off-by: Kir Kolyshkin <[email protected]>
AkihiroSuda
approved these changes
Aug 2, 2021
mrunalp
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticing that
runc execexit status is not documented, I ended up with this.Currently there's no way to distinguish between the two cases:
This was possible before commit 8477638, as runc exec exited with
the code of 255 if exec itself has failed. The code of 255 is the same
convention as used by e.g. ssh.
Re-introduce the feature, document it, and add some tests so it won't be
broken again.
Changelog entry