hard code ingress

terraform/modules/services/eb_app/security_group.tf

@@ -6,12 +6,22 @@ resource "aws_security_group" "sg" {
   vpc_id      = var.aws-vpc_id
 
   ingress {
-    from_port = var.ingress_from_port
-    to_port   = var.ingress_to_port
+    from_port = "80"
+    to_port   = "80"
     protocol  = "tcp"
     self      = true
   }
 
+  # TODO tidy this up, as its only needed for Data Platform
+  # 
+  ingress {
+    from_port        = "50051"
+    to_port          = "50051"
+    protocol         = "-1"
+    cidr_blocks      = ["0.0.0.0/0"]
+    ipv6_cidr_blocks = ["::/0"]
+  }
+
   egress {
     from_port        = 0
     to_port          = 0

terraform/modules/services/eb_app/variables.tf

@@ -76,18 +76,6 @@ variable container-host-port {
   default = 80
 }
 
-variable ingress_from_port {
-  type = number
-  description = "The from port, used for ingress"
-  default = 80
-}
-
-variable ingress_to_port {
-  type = number
-  description = "The to port, used for ingress"
-  default = 80
-}
-
 // EB configuration --------------------------------------------------------
 
 variable eb-app_name {

terraform/nowcasting/development/main.tf

@@ -308,6 +308,4 @@ module "data_platform_api" {
   s3_bucket = []
   container-host-port = "50051"
   container-port = "50051"
-  ingress_from_port = "50051"
-  ingress_to_port = "50051"
 }