- 
                Notifications
    
You must be signed in to change notification settings  - Fork 38
 
Feature/registration nag screen 336 #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature/registration nag screen 336 #1434
Conversation
| 
           Use  Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up.  | 
    
| 
           This pull request has conflicts ☹  | 
    
        
          
                src/components/Header.tsx
              
                Outdated
          
        
      | // un comment the below line after the test | ||
| // const notLocalhost = window.location.hostname !== "localhost"; | ||
| // for testing purposes on the local host | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // un comment the below line after the test | |
| // const notLocalhost = window.location.hostname !== "localhost"; | |
| // for testing purposes on the local host | |
| const notLocalhost = window.location.hostname !== "localhost"; | 
I would also suggest flipping the logic here and making it this:
| // un comment the below line after the test | |
| // const notLocalhost = window.location.hostname !== "localhost"; | |
| // for testing purposes on the local host | |
| const isLocalhost = window.location.hostname == "localhost"; | 
such that the if stanza on :148 reads if (isAdmin && dismissedLongEnough && !isLocalhost) {, which (IMO) reads cleaner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Done 🙂
Hello
please review the code , i have been trying to fix the issue which is stated at #336
thank you for your time
bests
Ensiyeh