Skip to content

Conversation

@EnsiyehE
Copy link
Contributor

Hello

please review the code , i have been trying to fix the issue which is stated at #336

thank you for your time
bests
Ensiyeh

@github-actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1434

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1434

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@gregorydlogan gregorydlogan added the type:bug Something isn't working label Sep 17, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Comment on lines 140 to 142
// un comment the below line after the test
// const notLocalhost = window.location.hostname !== "localhost";
// for testing purposes on the local host
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// un comment the below line after the test
// const notLocalhost = window.location.hostname !== "localhost";
// for testing purposes on the local host
const notLocalhost = window.location.hostname !== "localhost";

I would also suggest flipping the logic here and making it this:

Suggested change
// un comment the below line after the test
// const notLocalhost = window.location.hostname !== "localhost";
// for testing purposes on the local host
const isLocalhost = window.location.hostname == "localhost";

such that the if stanza on :148 reads if (isAdmin && dismissedLongEnough && !isLocalhost) {, which (IMO) reads cleaner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Done 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants