Skip to content

Conversation

@EnsiyehE
Copy link
Contributor

@EnsiyehE EnsiyehE commented Aug 27, 2025

Hello all,

This pull request fixes the events table selection behavior: when new events appear on the current page, any previously selected events that are no longer selected will correctly update the ‘select all’ checkbox to remain unselected.

This fixes #1253

thank you for your time
Ensiyeh

@github-actions
Copy link
Contributor

Hi @EnsiyehE
Thank you for contributing to the Opencast Admin UI.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@github-actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1412

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1412

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@lkiesow lkiesow changed the title PR for this issue Selection may change if events are modified in the background #1253 Fixing that the selection may change if events are modified in the background Aug 29, 2025
@gregorydlogan gregorydlogan added the type:bug Something isn't working label Sep 9, 2025
@gregorydlogan
Copy link
Member

The issue here is that it's going to unselect everything if even a single event gets added to the list. I think the original intent here was that the select all button was deselected, but the rest of the selected items remain selected. Is that something we can do?

@EnsiyehE
Copy link
Contributor Author

The issue here is that it's going to unselect everything if even a single event gets added to the list. I think the original intent here was that the select all button was deselected, but the rest of the selected items remain selected. Is that something we can do?

Hi Greg,

Thank you for the review!

I’ve updated the code accordingly so that adding a new event will now only deselect the “Select All” checkbox, while keeping the previously selected items intact.

Best regards,
Ensiyeh

@github-actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selection may change if events are modified in the background

2 participants