- 
                Notifications
    
You must be signed in to change notification settings  - Fork 38
 
Fixing that the selection may change if events are modified in the background #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| 
           Hi @EnsiyehE  | 
    
| 
           Use  Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up.  | 
    
| 
           The issue here is that it's going to unselect everything if even a single event gets added to the list. I think the original intent here was that the select all button was deselected, but the rest of the selected items remain selected. Is that something we can do?  | 
    
          
 Hi Greg, Thank you for the review! I’ve updated the code accordingly so that adding a new event will now only deselect the “Select All” checkbox, while keeping the previously selected items intact. Best regards,  | 
    
| 
           This pull request has conflicts ☹  | 
    
Hello all,
This pull request fixes the events table selection behavior: when new events appear on the current page, any previously selected events that are no longer selected will correctly update the ‘select all’ checkbox to remain unselected.
This fixes #1253
thank you for your time
Ensiyeh