Skip to content

Basebutton tooltip params #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Basebutton tooltip params #1402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/shared/BaseButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ const BaseButton = React.forwardRef<HTMLButtonElement, BaseButtonProps>(({

if (tooltipText) {
return (
<Tooltip title={tooltipParams ? t(tooltipText) : t(tooltipText, tooltipParams)}>
{buttonComponent}
<Tooltip title={tooltipParams ? t(tooltipText, tooltipParams) : t(tooltipText)}>
{buttonComponent}
Copy link
Member

@Arnei Arnei Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental removal to me?

Copy link
Contributor Author

@priya-tik priya-tik Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn’t accidental. I updated the expression to tooltipParams ? t(tooltipText, tooltipParams) : t(tooltipText) because the previous version caused an error. The change ensures that tooltipParams are passed to t() only when they exist, otherwise it falls back to the plain translation string.

Copy link
Member

@Arnei Arnei Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see know that the line I marked did not all make clear what I wanted to refer to. I am very sorry for the confusion, of course updating the expression as you did makes perfect sense. I was only referring to the removal of the tab character ^^`.

Copy link
Contributor Author

@priya-tik priya-tik Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it

</Tooltip>
);
}
Expand Down