fix(openapi-fetch): dynamic access to methods using wrapAsPathBasedClient #2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for openapi-ts failed.
|
🦋 Changeset detectedLatest commit: d9ae0d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
KajSzy
changed the title
KajSzy
changed the title
drwpow
approved these changes
May 4, 2025
Contributor
drwpow
left a comment
drwpow
left a comment
There was a problem hiding this comment.
Good fix, and great test, thank you!
Contributor
|
Not sure what happened with a couple cancelled tests, but all the tests that ran passed. The skipped ones shouldn’t matter. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using
wrapAsPathBasedClientto access methods of client dynamically it was throwing an error asthiscontext was not assigned toPathCallForwarderclass.Rewriting
PathCallForwarderto use arrow function fixes the issue.How to Review
I've added a test case which has example how
wrapAsPathBasedClientcan be used in generic function to retrieve methods, which also verifies the fix.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)