cryptpilot-convert&fde: use --key-file=- consistently to avoid newline issues in LUKS operations #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e issues in LUKS operations Previously, the script used `-` to pass passphrase via stdin to `cryptsetup`, which implicitly stops reading at newline. However, this behavior differs from `--key-file=-`, which reads all input including newlines (as documented in cryptsetup's man page). This inconsistency could lead to decryption failures if the passphrase contains or is followed by unexpected newlines, especially when the same input method is expected on both `luksFormat` and `open` calls. Changed all uses of: echo -n "pass" | cryptsetup ... - to: echo -n "pass" | cryptsetup ... --key-file=- This ensures consistent and predictable handling of passphrases read from stdin, avoiding potential mismatches due to line-ending interpretation. Also updated the Rust LUKS2 module to use `--key-file=-` for symmetry and safety. Fixes potential issue where rootfs unlock fails despite correct passphrase. Signed-off-by: Kun Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.